ref(build): release Docker image to GHCR via Craft #5509
Conversation
Uses Craft's new version
brain getting to much work
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| statusProvider: | ||
| name: github | ||
| config: | ||
| contexts: | ||
| - "Build Docker Image (relay)" |
There was a problem hiding this comment.
Bug: The .craft.yml configuration waits for a GitHub status check "Build Docker Image (relay)", but the workflow providing it is being removed, causing a release deadlock.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The .craft.yml file is configured with a statusProvider that waits for a GitHub status check named "Build Docker Image (relay)". However, the pull request removes the .github/workflows/release-ghcr-version-tag.yml workflow, which was the likely source for this status check. No other workflow in the repository is configured to produce a check with this specific name. As a result, the Craft release process will hang indefinitely or time out while waiting for a status check that will never be created, effectively blocking all releases.
💡 Suggested Fix
Update the statusProvider configuration in .craft.yml to wait for a status check that is produced by an existing workflow, or modify an existing workflow to produce the required "Build Docker Image (relay)" status check.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .craft.yml#L5-L9
Potential issue: The `.craft.yml` file is configured with a `statusProvider` that waits
for a GitHub status check named `"Build Docker Image (relay)"`. However, the pull
request removes the `.github/workflows/release-ghcr-version-tag.yml` workflow, which was
the likely source for this status check. No other workflow in the repository is
configured to produce a check with this specific name. As a result, the Craft release
process will hang indefinitely or time out while waiting for a status check that will
never be created, effectively blocking all releases.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7908621
There was a problem hiding this comment.
It is not. "Build Docker Image" is defined on ci.yml here https://github.com/aldy505/sentry-relay/blob/565a914c7944c5409fdd5c7e445ee275d7a75a30/.github/workflows/ci.yml#L492
aldy505
changed the title
2 participants
This is an ongoing effort to simplify the release process to not rely on the hacky GitHub Actions script that copies the Docker image after a release was created.
Part of getsentry/self-hosted#4123
REF SELF-78
#skip-changelog